Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving the status bar of Windows File Explorer (#6769) taken over after abandoned #12371 #12845

Merged
merged 9 commits into from
Nov 24, 2021

Conversation

lukaszgo1
Copy link
Contributor

First of all many thanks to @JulienCochuyt for most of this work.

Link to issue number:

Fixes #6769
Superseedes #12371

Summary of the issue:

Currently, the Window File Explorer cannot be retrieved using the reportStatusLine global command.

Description of how this pull request fixes the issue:

Testing strategy:

@JulienCochuyt 's testing:

  • Ran from source under Windows 10 20H2 19042.928 & 19042.964 both with a French locale.
  • Ensured expected result whether files are actually selected or not.

Additionally I've tested under Windows 7, Server 2012, Windows 10 1511, 1809 and latest preview of Windows 11 - in all cases status bar has been retrieved successfully.

Known issues with pull request:

May possibly not work under some version of Windows not described in the testing above, but since this code works from Server 2012 up to Windows 11 without any changes I consider this pretty unlikely.

Change log entries:

Changes

  • In Windows 8 and later , the File Explorer status bar can now be retrieved using the standard gesture NVDA+end (desktop) / NVDA+shift+end (laptop).

For Developers

  • Status bar text retrieval may now be customized by an AppModule.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • API is compatible with existing addons.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

Changes from #12371 :

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner September 14, 2021 09:12
@lukaszgo1
Copy link
Contributor Author

@michaelDCurran Since you're already familiar with the code from #12371 would you be able to review this? I believe I've addressed all your concerns from the review on that PR.

@CyrilleB79
Copy link
Collaborator

Tested on Windows 10 20H2 (64-bit) build 19042.1165.
I confirm that it is working on this version of Windows.

I hope to see it in NVDA 2021.3 for my own usage. This has also been requested many times in the French community.

@michaelDCurran do you think this PR could be added in 2021.3 milestone? Thanks.

@lukaszgo1
Copy link
Contributor Author

@michaelDCurran Given there is clearly a community demand for this, and that you've explained on #12371 what needs to happen for this being approved and all of these are addressed may I ask what stops this from being looked at?

@CyrilleB79
Copy link
Collaborator

Also CCing @feerrenrut to set a release milestone for this PR.

@feerrenrut feerrenrut added this to the 2022.1 milestone Oct 7, 2021
@lukaszgo1
Copy link
Contributor Author

There has been several request for this on the users list recently.

@michaelDCurran michaelDCurran merged commit 2695499 into nvaccess:master Nov 24, 2021
@lukaszgo1 lukaszgo1 deleted the pr12371OldWindowsVers branch November 24, 2021 08:54
seanbudd pushed a commit that referenced this pull request Dec 5, 2021
…me (#13135)

Fix-up of PR #12845

Summary of the issue:
PR #12845 added additional type hints to methods on appModuleHandler.AppModule. Unfortunately presence of these annotations can cause a crash when uninstalling add-ons importing gui in their installTasks module.

Description of how this pull request fixes the issue:
This PR takes advantage of Postponed Evaluation of Annotations introduced in PEP 563 to avoid type hints in appModuleHandler being evaluated at import time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read status bar in File Explorer (Windows 10)
5 participants