Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce highlight instead of marked #12892

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

feerrenrut
Copy link
Contributor

@feerrenrut feerrenrut commented Oct 1, 2021

Link to issue number:

Perhaps #4247 can be closed?

Prior work: #11436

Summary of the issue:

'mark' elements were being reported as "marked content".
This is long. Additionally, the standard visual representation of mark is a yellow background, as if the text has been highlighted.
Arguably, "highlighted" is a more common phrase in English.
It is also more specific to this visual representation.
The more generaral "marked" content could mean many different kinds of markings with varied semantics.
With the introduction of "role-description", less common usages of mark can be achived.

Description of how this pull request fixes the issue:

Use "highlight" instead of "marked content" for speech.
Use "hlght" instead of "mrkd" for braille

Testing strategy:

System tests

Known issues with pull request:

Some users may already be familiar with "marked content".

Change log entries:

Changes

- Instead of "marked content" or "mrkd", "highlight" or "hlight" will be announced for speech and braille respectively.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut
Copy link
Contributor Author

Marked (highlight) isn't announced in focus mode (as shown by the system test). I'll consider whether this is appropriate next.

@AppVeyorBot

This comment has been minimized.

@feerrenrut feerrenrut marked this pull request as ready for review October 6, 2021 10:32
@feerrenrut feerrenrut requested review from a team as code owners October 6, 2021 10:32
Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cary-rowen
Copy link
Contributor

This PR can solve #12101?

@feerrenrut
Copy link
Contributor Author

No @cary-rowen, this is specifically about the text used when reporting role_mark.

@feerrenrut feerrenrut merged commit fb4466e into master Oct 8, 2021
@feerrenrut feerrenrut deleted the changeMarkedToHighlighted branch October 8, 2021 05:42
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 8, 2021
seanbudd pushed a commit that referenced this pull request Nov 2, 2021
seanbudd added a commit that referenced this pull request Nov 3, 2021
Follow up of #12892

Summary of the issue:
A usage of "marked text" still remains, while other usages have been replaced with "highlighted text"

Description of how this pull request fixes the issue:
Replaces marked text with highlighted text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants