Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to SAPI5 synthDriver and move constants to Enums #12927

Merged
merged 6 commits into from
Oct 20, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Oct 13, 2021

Link to issue number:

None

Summary of the issue:

While debugging #12913, I created some Enums and added more logging.
This is not a focused refactor, and as such, more work could be done to improve the SAPI 5 driver.

Description of how this pull request fixes the issue:

  • Implements IntEnums for constants
  • Adds logging
  • Clean up imports

Testing strategy:

Test the SAPI5 synthesizer

Known issues with pull request:

#12913

Note, this is an API breaking change and should not be merged until 2022.1.
I have just created this PR as the work should not be lost, but adding backwards compatibility is not worth prioritising.

Change log entries:

See diff in changes.t2t

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd added this to the 2022.1 milestone Oct 13, 2021
@seanbudd seanbudd marked this pull request as ready for review October 19, 2021 22:55
@seanbudd seanbudd requested a review from a team as a code owner October 19, 2021 22:55
source/synthDrivers/sapi5.py Outdated Show resolved Hide resolved
source/synthDrivers/sapi5.py Outdated Show resolved Hide resolved
@seanbudd seanbudd merged commit 0eb6bcb into master Oct 20, 2021
@seanbudd seanbudd deleted the refactor-SAPI5 branch October 20, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants