Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Espeak for 2022.1 #12950

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Update Espeak for 2022.1 #12950

merged 3 commits into from
Oct 19, 2021

Conversation

feerrenrut
Copy link
Contributor

Link to issue number:

None

Summary of the issue:

With the start of the 2022.1 dev cycle, update Espeak-ng

Description of how this pull request fixes the issue:

Updates Espeak-ng

Testing strategy:

Built and run locally
Rely on alpha testers for deeper testing.

Known issues with pull request:

None

Change log entries:

Changes

- Espeak-ng has been updated to commit 7e5457f91e10

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut requested a review from a team as a code owner October 18, 2021 09:57
@feerrenrut
Copy link
Contributor Author

Blocked by #12949

@AppVeyorBot
Copy link

See test results for failed build of commit fd67298214

@codeofdusk
Copy link
Contributor

Any chance of including up through commit espeak-ng/espeak-ng@2bba3ad?

@feerrenrut
Copy link
Contributor Author

Those commits weren't available yesterday when I created this PR.

I have tried building commit 2bba3ad3 but there is an error:

espeak_compileDict_buildAction(["include\espeak\espeak-ng-data\ar_dict"], ["include\espeak\dictsource\ar_listx", "include\espeak\dictsource\ar_list", "include\espeak\dictsource\ar_rules"])
Error: The requested functionality has not been built into espeak-ng.
scons: *** [include\espeak\espeak-ng-data\ar_dict] ValueError : 2 is not a valid espeak_ng_STATUS
ValueError: 2 is not a valid espeak_ng_STATUS

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\work\repo\nvda\6\.venv\lib\site-packages\SCons\Action.py", line 1280, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\work\repo\nvda\6\build\x86\espeak\sconscript", line 325, in espeak_compileDict_buildAction
    f"Failed to compile dictionary: '{target}'"
  File "C:\Users\reef-\AppData\Local\Programs\Python\Python37-32\lib\enum.py", line 315, in __call__
    return cls.__new__(cls, value)
  File "C:\Users\reef-\AppData\Local\Programs\Python\Python37-32\lib\enum.py", line 569, in __new__
    raise exc
  File "C:\Users\reef-\AppData\Local\Programs\Python\Python37-32\lib\enum.py", line 553, in __new__
    result = cls._missing_(value)
  File "C:\Users\reef-\AppData\Local\Programs\Python\Python37-32\lib\enum.py", line 582, in _missing_
    raise ValueError("%r is not a valid %s" % (value, cls.__name__))
ValueError: 2 is not a valid espeak_ng_STATUS

I'm going ahead with the commit selected previously.

@feerrenrut feerrenrut merged commit 8d8f606 into master Oct 19, 2021
@feerrenrut feerrenrut deleted the updateEspeak2022.1 branch October 19, 2021 07:40
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 19, 2021
@feerrenrut feerrenrut modified the milestones: 2021.3, 2022.1 Oct 20, 2021
@codeofdusk
Copy link
Contributor

@feerrenrut It looks like those errors still exist as of latest master. Maybe something changed in the build system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants