Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winVersion: remove deprecated Windows 10 releases to builds map #13211

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Jan 3, 2022

Hi,

This completes the work began in 2021:

Link to issue number:

Removes deprecated code from #12509

Summary of the issue:

As of #12544, Windows 10 releases to builds map was deprecated, with what's new document declaring that this map will be gone in 2022.1. This pull request accomplishes exactly that.

Description of how this pull request fixes the issue:

Removes deprecated Windows 10 releases to builds as Windows Registry is used to obtain Windows 10/11 release information.

Testing strategy:

Manual and unit tests:

  1. Make sure unit tests do not fail, specificlaly winVersion test suite.
  2. Make sure Python raises attribute error when trying to fetch the deprecated (and removed) map.

Known issues with pull request:

None

Change log entries:

Changes for developers:

winVersion.WIN10_RELEASE_NAME_TO_BUILDS is removed.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@josephsl josephsl requested a review from a team as a code owner January 3, 2022 07:13
@josephsl josephsl requested a review from seanbudd January 3, 2022 07:13
@seanbudd seanbudd merged commit 49168d5 into nvaccess:master Jan 13, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 13, 2022
@josephsl josephsl deleted the winVersionRemoveDeprecatedContents branch January 21, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants