Skip to content

HID Braille: allow all gesture bindings to function again #13228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

michaelDCurran
Copy link
Member

Link to issue number:

None

Summary of the issue:

When using a braille display with the HID Braille driver, none of the gesture bindings (such as scrolling, routing etc) function anymore.
This was broken in commit dd24001 between 2021.3 and 2021.3.1.
In this commit, the HID braille driver was renamed to hidBrailleStandard, however, all the gesture bindings within the driver were not updated to reflect the rename.

Description of how this pull request fixes the issue:

Correct the driver name on all gesture bindings in this driver to reference hidBrailleStandard instead of HID.

Testing strategy:

Connected to an Orbit reader 40 in HID Braille mode and tested all bound gestures.

Known issues with pull request:

None.

Change log entries:

New features
Changes
Bug fixes

  • Gestures such as scrolling and routing again work with HID Braille devices.

For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

Correct all Braille gesture bindings to reference 'hidBrailleStandard' rather than 'HID'.
@michaelDCurran michaelDCurran requested a review from a team as a code owner January 10, 2022 23:54
@AppVeyorBot
Copy link

See test results for failed build of commit 0c3b1b5582

@LeonarddeR
Copy link
Collaborator

Couldn't we replace
"br(hidBrailleStandard
with:
f"br({BrailleDisplayDriver.name}

@michaelDCurran michaelDCurran merged commit cc7aabe into master Jan 14, 2022
@michaelDCurran michaelDCurran deleted the fixHidBrailleGestures branch January 14, 2022 01:11
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants