Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated loadState and saveState from addonHandler #13245

Merged

Conversation

lukaszgo1
Copy link
Contributor

Link to issue number:

Removes code deprecated as part of PR #12792

Summary of the issue:

PR #12792 converted state in addonHandler to a class deprecating some module level functions in the process.

Description of how this pull request fixes the issue:

Deprecated loadState and saveState are removed from addonHandler.

Testing strategy:

With git grep made sure that these functions are not used anywhere in the source code.

Known issues with pull request:

None known

Change log entries:

For Developers

  • Functions loadState and saveState are removed from addonHandler - please use addonHandler.state.load and addonHandler.state.save instead.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner January 17, 2022 13:07
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukaszgo1

@seanbudd seanbudd merged commit 9092227 into nvaccess:master Jan 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 18, 2022
@lukaszgo1 lukaszgo1 deleted the addonHandlerRemoveDeprecatedFunctions branch January 18, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants