-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove windowsPrimaryLCIDsToLocaleNames #13342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
feerrenrut
suggested changes
Feb 16, 2022
feerrenrut
approved these changes
Feb 16, 2022
# Conflicts: # source/languageHandler.py
See test results for failed build of commit b344b8b2bf |
lukaszgo1
suggested changes
Feb 16, 2022
seanbudd
force-pushed
the
fixLCIDLookup
branch
from
February 16, 2022 21:19
f40f4a9
to
b643ec5
Compare
# Conflicts: # user_docs/en/changes.t2t
seanbudd
force-pushed
the
fixLCIDLookup
branch
from
February 16, 2022 21:20
b643ec5
to
d04e0dd
Compare
lukaszgo1
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for applying these changes @seanbudd ! LGTM
feerrenrut
reviewed
Feb 17, 2022
feerrenrut
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The latest PR (#13338) to merge beta to master has failed, due to Bangla translations being introduced and
windowsPrimaryLCIDsToLocaleNames
not listing the locale. AppVeyor build failure.On #13339, @CyrilleB79 raised that this variable is poorly documented and outdated.
The initial variable provided a mapping of LCIDs to language codes, without the rest of the locale.
We now normalize the locale as necessary in
normalizeLanguage
instead.On further inspection, it appears that the only additions from
locale.windows_locale
are as follows:As
locale.windows_locale
is incomplete, these were introduced to ensure languages translated in NVDA could be mapped.Instead, the Windows function
LCIDToLocaleName
can be used to get each of these locales.This was suggested in #4203.
However Windows maps
1170
to "ku-Arab-IQ" not "ckb", and a translation is added for Central Kurdish in localesData.LANG_NAMES_TO_LOCALIZED_DESCS["ckb"]. NVDA may drop "Arab-IQ" from this locale to get the language, losing the locality of "Central Kurdish".Description of how this pull request fixes the issue:
Removes
windowsPrimaryLCIDsToLocaleNames
, instead useLCIDToLocaleName
after checking for an internal mapping (eg for "ckb").Testing strategy:
my
locale in NVDA (previously hardcoded mapping)Known issues with pull request:
None
Change log entries:
For Developers
Code Review Checklist: