Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scons: revert providing the number of logical processors as the number of maximum concurrent jobs to speed up builds by default #13371

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Feb 21, 2022

Link to issue number:

Reverts #13226

Summary of the issue:

While building NVDA with multiple jobs leads to faster build times, it also leads to scrambled output which can be quite annoying when debugging.

Description of how this pull request fixes the issue:

Disable multiple jobs by default but warn users to run with -jX to get a faster build if applicable.

Testing strategy:

Tested specifying several numbers of build jobs on the command line

Known issues with pull request:

None known

Change log entries:

included in pr

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

…r of maximum concurrent jobs to speed up builds by default
@LeonarddeR LeonarddeR requested a review from a team as a code owner February 21, 2022 18:21
@seanbudd

This comment was marked as off-topic.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR , we are going with this approach

@seanbudd seanbudd merged commit 8581f56 into nvaccess:master Mar 3, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants