Avoid ValueError with ARIA rowindex/colindex/rowcount/colcount in Firefox #13405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAClause
force-pushed
the
aria-table-presentational-fix
branch
2 times, most recently
from
ae54d56 to
b9ad3f3
Compare
AAClause
force-pushed
the
aria-table-presentational-fix
branch
from
b9ad3f3 to
91aa035
Compare
michaelDCurran
approved these changes
Mar 9, 2022
feerrenrut
added a commit
that referenced
this pull request
Mar 15, 2022
5 tasks
feerrenrut
added a commit
that referenced
this pull request
Mar 17, 2022
feerrenrut
added a commit
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13404
Summary of the issue:
A bad value for
aria-colcount,aria-rowcount,aria-colindexandaria-rowindexattributes causes a bug.Description of how this pull request fixes the issue:
Make sure the value is numeric before casting it to integer, otherwise exclude it.
Testing strategy:
Tested with the following HTML Code Snippets (which were previously problematic now work properly):
<div role="grid" aria-colcount>Empty value (colcount)</div><div role="grid" aria-rowcount>Empty value (rowcount)</div><div role="grid" aria-colcount="abc">Wrong value (colcount)</div><div role="grid" aria-rowcount="abc">Wrong value (rowcount)</div><div role="grid" aria-colcount="-1">The table size is not known (colcount)</div><div role="grid" aria-rowcount="-1">The table size is not known (rowcount)</div>References:
Known issues with pull request:
None but I think we should improve the restitution when
aria-colcountand/oraria-rowcountis set to -1.Change log entries:
Bug fixes:
- In Firefox, NVDA no longer fails to report items in web pages when aria-rowindex, aria-colindex, aria-rowcount or aria-colcount attributes are invalid. (#13405)Code Review Checklist: