Fix Excel error due to state enum changes #13465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #13457
Summary of the issue:
With UIA for Excel disabled, navigating to a cell with a formula and "has formula" is not reported.
This is a regression caused by #13414
In
NVDAHelper/remote/excel.cpp
the properties of a cell are determined and bits are set on thestate
member of aEXCEL_CELLINFO
struct.The constatnts used for this are in
NVDAHelper/remote/excel/Constants.h
, see theNVSTATE_*
constants, previously these matched thecontrolTypes.State
constants directly.Description of how this pull request fixes the issue:
Rather than couple the excel implementation to the controlTypes implementation, these constants have been converted to enums (both in C++ and in Python), renumbered, and an explicit mapping to the corresponding
controlTypes.State
enum has been created.Testing strategy:
Known issues with pull request:
None
Change log entries:
For Developers
Code Review Checklist: