-
-
Notifications
You must be signed in to change notification settings - Fork 678
Initialize MathPlayer when NVDA starts #13486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I confirmed NVDA's MathPlayer support still functions after this change. E.g. I was able to read and interact with math in MS Word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought, should mathPres also be terminateable as well as be terminated/initialized in core.resetConfiguration?
Link to issue number:
Fixes #13463
Summary of the issue:
mathPres.ensureInit
is called whenever math content is expected to be read, including from getTextWithFields.This is called with every read when using UIA with Word.
If mathPlayer is not installed, this pollutes the log.
Ideally, math should be initialized at NVDA startup time.
Description of how this pull request fixes the issue:
Makes mathPlayer initialize on start up.
Removes
mathPlayer.ensureInit
usages from within NVDA.External documentation referencing mathPlayer may need to be updated to reflect the need to restart NVDA after installing mathPlayer.
Testing strategy:
Known issues with pull request:
None
Change log entries:
Changes
For Developers
Code Review Checklist: