Skip to content

MS Word with UIA: do not fetch text-column-number as this causes MS Word to crash #13515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Mar 21, 2022

Link to issue number:

Fixes #13511
Fixes #13503

Summary of the issue:

Fetching text-column-number using UIA custom patterns in MS Word, causes MS Word to crash.
this can happen when opening a blank document on MS Word start-up.
This has been reported to Microsoft.

Description of how this pull request fixes the issue:

No longer fetch text-column-number in MS Word with UIA. This should only be reenabled in future for newer versions of MS Word identified not to crash.

Testing strategy:

Opened a blank document in MS Word. MS Word no longer crashes on start-up. Confirmed that other custom attributes such as section number and bookmark still get reported.

Known issues with pull request:

None known.

Change log entries:

None needed.

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@michaelDCurran michaelDCurran requested a review from a team as a code owner March 21, 2022 01:57
@michaelDCurran michaelDCurran requested review from seanbudd and removed request for a team March 21, 2022 01:57
@michaelDCurran michaelDCurran added this to the 2022.1 milestone Mar 21, 2022
@michaelDCurran michaelDCurran merged commit fae6428 into beta Mar 21, 2022
@michaelDCurran michaelDCurran deleted the i13511 branch March 21, 2022 02:53
seanbudd added a commit that referenced this pull request Mar 21, 2022
seanbudd added a commit that referenced this pull request Mar 21, 2022
Follow up of #13515, fixes the change log for 2022.1beta2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants