Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for navigator object highlighting activation #13641

Merged
merged 6 commits into from
May 23, 2022

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

When activating Highlight of navigator object, the highlighting rectangle does not show up. It only shows up when the navigator object is moved for the first time. If the highlight of nav object is previously disabled, the issue occurs for all the four following types of activation:

  1. When checking the corresponding checkbox in the vision parameters
  2. When you reload NVDA's saved config provided that highlighter is enabled in NVDA's saved config.
  3. When activating with a gesture a profile containing nav object highlight enabled
  4. When NVDA starts up if the default config has nav object highlight enabled

Description of how this pull request fixes the issue:

Checks nav object initialization when the providers are initialized. Prior to this PR, only the focus initialization was checked (and the caret thanks to it).

Testing strategy:

Manually tested the 4 cases described in the section "Summary of the issue".
All successful.
Test 3 successful provided that you are not in the case described in #13640.

Known issues with pull request:

Test 3 may fail due to #13640. But it works once you have executed the whole STR of #13640.

Change log entries:

Bug fixes
Navigator object highlighting now shows up immediately upon activation of the feature.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot
Copy link

See test results for failed build of commit 6ca5e5b796

@CyrilleB79 CyrilleB79 marked this pull request as ready for review April 26, 2022 12:51
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner April 26, 2022 12:51
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 27, 2022
source/vision/visionHandler.py Outdated Show resolved Hide resolved
source/vision/visionHandler.py Show resolved Hide resolved
@seanbudd seanbudd merged commit f80b755 into nvaccess:master May 23, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 23, 2022
@CyrilleB79 CyrilleB79 deleted the enableHighlight branch May 24, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants