Add new script to report accelerator key of currently focused object

[codeofdusk]

Link to issue number:

None (reported privately by @DHowett via @carlos-zamora).

Summary of the issue:

There is no way to simply obtain the accelerator key of the currently focused object without reading its entire description.

Description of how this pull request fixes the issue:

Adds a new script to report the accelerator key. By default, it is bound to Shift+numpad 2 (desktop) and Ctrl+Shift+NVDA+. (laptop). As a mnemonic, accelerator keys are (or at least used to be) visually displayed by an underlined character.

Testing strategy:

Tested Windows 11 Notepad (UIA), NVDA menus (MSAA), Google Chrome (MSAA), and Foobar 2000 (MSAA).

Known issues with pull request:

None known.

Change log entries:

== New Features ==

• Added a new command to check the keyboard shortcut of the current focus (by default, Shift+Numpad 2 on desktop and Ctrl+Shift+NVDA+. on laptop).

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English

[seanbudd]

@codeofdusk I'm not sure - it would be good to get an answer on this even if it's a separate issue / discussion / PR

[codeofdusk]

@seanbudd It appears the issues I was having with MSAA apps were caused by me binding the script to a command that caused the menus to close. Setting a default gesture (based on the "current character" commands) seems to resolve the issue.

[codeofdusk]

PR now ready for review/merge.

[CyrilleB79]

I am a bit concerned by the use of Numpad for the default gesture.
Numpad key are usually used for interactions with the review cursor. Shouldn't we reserve the use of these keys for the review cursor?
@Qchristensen , @lukaszgo1 what do you think?

Could we find another key combination or keep it unbound by default?

[codeofdusk]

I am a bit concerned by the use of Numpad for the default gesture.
Numpad key are usually used for interactions with the review cursor. Shouldn't we reserve the use of these keys for the review cursor?

@CyrilleB79 Similarity to review cursor keys is intended:

As a mnemonic, accelerator keys are (or at least used to be) visually displayed by an underlined character.

So this is the "current character" command with modifiers.

[CyrilleB79]

I am a bit concerned by the use of Numpad for the default gesture.
Numpad key are usually used for interactions with the review cursor. Shouldn't we reserve the use of these keys for the review cursor?

@CyrilleB79 Similarity to review cursor keys is intended:

As a mnemonic, accelerator keys are (or at least used to be) visually displayed by an underlined character.

So this is the "current character" command with modifiers.

I have understood that you want to find a similarity with a character command since accelerator key is an underlined character.
But IMO, it's more interesting to separate review command from the other ones than than finding an easy-to-remember gesture for this specific comand. Indeed, the difference between review cursor, browse mode cursor and system cursor is sometimes hard to understand for some users (not me); and all what can help to make this difference more noticeable is a plus.

Anyway, I have expressed my opinion now. But if I am the only one to think this way, just go forward with this PR as is; that's not so important.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests. See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/kceaua7wh6sfnu2q/artifacts/output/nvda_snapshot_pr13960-26052,87b7c545.exe

See test results for failed build of commit 87b7c54570

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests. See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/pa50w60bk8ubnhft/artifacts/output/nvda_snapshot_pr13960-26055,0e65abd4.exe

See test results for failed build of commit 0e65abd4a1

[codeofdusk]

@seanbudd Failure seems unrelated.

[Qchristensen]

Great work, will be well appreciated.