Send architecture when update checking #14019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
reviewed
Aug 16, 2022
seanbudd
reviewed
Aug 16, 2022
| @@ -119,7 +119,8 @@ def checkForUpdate(auto: bool = False) -> Optional[Dict]: | |||
| "version": versionInfo.version, | |||
| "versionType": versionInfo.updateVersionType, | |||
| "osVersion": winVersionText, | |||
| "x64": os.environ.get("PROCESSOR_ARCHITEW6432") == "AMD64", | |||
| "x64": os.environ.get("PROCESSOR_ARCHITEW6432") in ("AMD64", "ARM64"), | |||
| "osArchitecture": os.environ.get("PROCESSOR_ARCHITEW6432"), | |||
There was a problem hiding this comment.
this change will require server side changes (to be recorded)
There was a problem hiding this comment.
This should be safe to merge as-is, with changes to the server implemented later
There was a problem hiding this comment.
It's worth raising that this is additional user tracking.
I don't think it is a big leap from tracking x64 vs x86.
The only difference is tracking which x64-bit architecture is in use, out of (AMD64, ARM64, IA64).
One potential negative - considering ARM64 and IA64 are more unusual, getting a thumbprint of a user based on their update check might become easier in theory.
seanbudd
added
the
conceptApproved
seanbudd
previously approved these changes
Aug 17, 2022
seanbudd
reviewed
Aug 18, 2022
seanbudd
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
It was discovered in #12064 that NVDA sends the architecture to the update server when updating, but it doesn't properly distinguish between architectures. Therefore, NVDA should send which architecture is in use specifically.
Description of user facing changes
None, only for usage stats.
Description of development approach
Consistency of data is kept by not changing how the x64 key is determined in the dictionary.
The specific architecture is added as an extra key to the dictionary.
Testing strategy:
Known issues with pull request:
None
Change log entries:
Changes
Code Review Checklist: