-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable UIA text change events outside of Word, Windows Console, and Windows Terminal #14067
Conversation
ec92a87
to
4762bd3
Compare
Note that you need to add "_WwG" as well since word also relies on text change events |
@LeonarddeR Done. For some reason, start menu suggestions aren't reading with this PR. |
May be @josephsl knows a reason for this, though I don't see how textChange events are used there. |
Never mind, even when running |
See test results for failed build of commit 820eb60520 |
@seanbudd Why was the build cancelled for this PR? |
e93544d
to
6bf9745
Compare
@codeofdusk - please don't force push to the branch after approval |
@seanbudd OK. I just tried doing that to see if it'd re-trigger the build. There are no code changes. |
@codeofdusk - the build was cancelled intentionally. Releases take priority for builds. |
Oh OK. Will you restart the build for this PR after the release? |
See test results for failed build of commit 5c330d899c |
See test results for failed build of commit 5c330d899c |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
See test results for failed build of commit 04337168d0 |
Link to issue number:
Mitigation for #11002.
Blocking #14047.
Summary of the issue:
UIA
textChange
NVDA events are seldom (if ever) used outside of a few specific situations, but have an extreme performance impact (see #11002).Description of user facing changes
Improved performance/less chance of NVDA hanging in UIA applications.
Description of development approach
Explicitly do not process UIA
textChange
events outside of Windows Console, Terminal, and Word. The eventual end goal is to removeTermControl
/TermControl2
fromUIAHandler.textChangeUIAClassNames
in #14047, which will very greatly improve performance in Windows Terminal. (conhost
will remain, as there don't seem to be any plans to add notifications, especially aswt
is becoming the default).I'm very reluctant to add a mechanism by which add-ons/app modules can request
textChange
events unless someone requests it, especially given #11002.Testing strategy:
conhost
andwt
remain functional.TermControl
fromtextChangeUIAClassNames
and verified thattextChange
events are not received.Known issues with pull request:
None known.
Change log entries:
== Changes for Developers ==
textChange
events for most UI Automation applications due to their extreme negative performance impact. (UIA freezes after a large number of events is received #11002, Disable UIA text change events outside of Word, Windows Console, and Windows Terminal #14067)Code Review Checklist: