Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eSpeak to commit 0dbe7182 #14079

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Update eSpeak to commit 0dbe7182 #14079

merged 2 commits into from
Aug 29, 2022

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Aug 28, 2022 •
edited by seanbudd
Loading

Link to issue number:

#13945, espeak-ng/espeak-ng#1230.

Summary of the issue:

There has been a few minor fixes since the first time eSpeak was bumped for 2022.4

A few number processing fixes (including for a possible buffer overrun and incorrect synthesis for mto) were missed in the last PR.

Description of how this pull request fixes the issue:

Bump eSpeak version.

Testing strategy:

Tested in self-signed build as running copy of NVDA.

Known issues with pull request:

None known.

Change log entries:

See PR.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner August 28, 2022 22:50
@codeofdusk codeofdusk requested a review from seanbudd August 28, 2022 22:50
@codeofdusk codeofdusk force-pushed the update-espeak-2022.4 branch from 135a209 to 1914447 Compare August 28, 2022 22:51
@seanbudd seanbudd changed the title Update eSpeak to commit 0dbe718 Update eSpeak to commit 0dbe7182 Aug 29, 2022
seanbudd
seanbudd reviewed Aug 29, 2022
View reviewed changes
readme.md Outdated Show resolved Hide resolved
user_docs/en/changes.t2t Outdated Show resolved Hide resolved
@seanbudd seanbudd merged commit 14bbc7c into nvaccess:master Aug 29, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.4
Development

Successfully merging this pull request may close these issues.
3 participants
@codeofdusk @seanbudd @nvaccessAuto