Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to 3.23.0 #14112

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Update liblouis to 3.23.0 #14112

merged 2 commits into from
Sep 13, 2022

Conversation

AAClause
Copy link
Contributor

@AAClause AAClause commented Sep 7, 2022

Link to issue number:

None

Summary of the issue:

Liblouis 3.23.0 has been released.

Description of user facing changes

Updates liblouis to 3.23.0 which adds new braille tables. Changelog.

Description of development approach

Update liblouis submodule, add new builtin tables and map an old table name to new table.

Testing strategy:

Ran from sources and loaded new braille tables. LGTM.

Known issues with pull request:

None

Change log entries:

Section: Changes

- Updated liblouis braille translator to [3.23.0 https://github.com/liblouis/liblouis/releases/tag/v3.23.0]. (#14112)
  - New braille table: Chinese common braille (simplified Chinese characters), Kinyarwanda literary braille, Luganda literary braille, Swedish uncontracted braille, Swedish partially contracted braille, Swedish contracted braille

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot
Copy link

See test results for failed build of commit 1016d559b2

@zstanecic
Copy link
Contributor

zstanecic commented Sep 7, 2022 via email

@AAClause
Copy link
Contributor Author

AAClause commented Sep 7, 2022

@zstanecic Already done.

@AAClause AAClause marked this pull request as ready for review September 12, 2022 06:20
@AAClause AAClause requested a review from a team as a code owner September 12, 2022 06:20
@seanbudd seanbudd merged commit 041609e into nvaccess:master Sep 13, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants