-
-
Notifications
You must be signed in to change notification settings - Fork 679
Added Simplified Chinese Braille table 'Chinese (China, Mandarin) Current Braille System (no tones)' #14138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
reviewed
Sep 13, 2022
… notes for zhcn-cbs.
@seanbudd |
seanbudd
reviewed
Sep 13, 2022
seanbudd
reviewed
Sep 13, 2022
seanbudd
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cary-rowen
See test results for failed build of commit cb4e06e144 |
See test results for failed build of commit cb4e06e144 |
See test results for failed build of commit 8a26449582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
zh-chn.ctb is a variant of the Chinese Current Braille System(zhcn-g1.ctb), which omits tones and allows for more braille content to be displayed for small braille displays.
In the nvda Chinese community, some people hope that this braille table can also be a candidate.
But there is no way to do this without manually renaming the table to replace the existing table.
So, I added it to braille settings dialog.
Description of user facing changes
Added Simplified Chinese Braille table 'Chinese(Current Braille System (no tones)'
Description of development approach
Add the definition of the table in brailleTables.py.
Testing strategy:
Manual testing.
Known issues with pull request:
None
Change log entries:
Changes
Code Review Checklist: