-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for embedded WPFTermControl in LTS Visual Studio #14194
Add support for embedded WPFTermControl in LTS Visual Studio #14194
Conversation
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Once this PR is ready/approved, can you:
|
It appears that |
I think just a result of the branch change on GitHub. Should I rebase on master too? |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
I don't think it is, it was changed in this commit: 1d3b781
No, we want this PR to retarget the branch for 2022.4 still |
@@ -1182,17 +1182,29 @@ def findOverlayClasses(self,clsList): | |||
from . import VisualStudio | |||
VisualStudio.findExtraOverlayClasses(self, clsList) | |||
|
|||
# Support Windows Console's UIA interface | |||
# Support Windows Console and Terminal | |||
_all_wt_UIAClassNames = frozenset(( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think typical syntax for this is the following, but I don't think it matters
_all_wt_UIAClassNames = frozenset(( | |
_all_wt_UIAClassNames = frozenset({ |
Link to issue number:
None.
Summary of the issue:
Visual Studio uses a WPF implementation of the Windows Terminal control that will use a different UIA class name. As such, NVDA currently does not add the needed overlay class to this control, so autoread and password suppression do not work as expected.
Description of how this pull request fixes the issue:
Added the new UIA class name to the necessary lists.
Testing strategy:
N/A
Known issues with pull request:
Given that this is a small, targetted bug fix, please merge to 2022.4.
Change log entries:
=== Bug Fixes ===
Code Review Checklist: