Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedded WPFTermControl in LTS Visual Studio #14194

Merged
merged 9 commits into from
Sep 29, 2022

Conversation

codeofdusk
Copy link
Contributor

Link to issue number:

None.

Summary of the issue:

Visual Studio uses a WPF implementation of the Windows Terminal control that will use a different UIA class name. As such, NVDA currently does not add the needed overlay class to this control, so autoread and password suppression do not work as expected.

Description of how this pull request fixes the issue:

Added the new UIA class name to the necessary lists.

Testing strategy:

N/A

Known issues with pull request:

Given that this is a small, targetted bug fix, please merge to 2022.4.

Change log entries:

=== Bug Fixes ===

  • Text reporting, Braille output, and password suppression now work as expected in the embedded Windows Terminal control in Visual Studio 2022.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner September 29, 2022 00:40
@codeofdusk codeofdusk requested review from seanbudd and removed request for a team September 29, 2022 00:40
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@seanbudd
Copy link
Member

Once this PR is ready/approved, can you:

  • Update the changes file yourself, as 2022.4 is frozen, merge conflicts are unlikely
  • Temporarily re-target the final PR against master, so that a branch build occurs
  • Re-target the PR to branchFor2022.4 after a successful build

@codeofdusk codeofdusk changed the base branch from branchFor2022.4 to master September 29, 2022 03:06
@seanbudd
Copy link
Member

It appears that include/sonic has been mistakenly reverted to an earlier commit in this PR

@codeofdusk
Copy link
Contributor Author

I think just a result of the branch change on GitHub. Should I rebase on master too?

Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@seanbudd
Copy link
Member

I think just a result of the branch change on GitHub.

I don't think it is, it was changed in this commit: 1d3b781

Should I rebase on master too?

No, we want this PR to retarget the branch for 2022.4 still

@@ -1182,17 +1182,29 @@ def findOverlayClasses(self,clsList):
from . import VisualStudio
VisualStudio.findExtraOverlayClasses(self, clsList)

# Support Windows Console's UIA interface
# Support Windows Console and Terminal
_all_wt_UIAClassNames = frozenset((
Copy link
Member

@seanbudd seanbudd Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think typical syntax for this is the following, but I don't think it matters

Suggested change
_all_wt_UIAClassNames = frozenset((
_all_wt_UIAClassNames = frozenset({

@seanbudd seanbudd added this to the 2022.4 milestone Sep 29, 2022
@AppVeyorBot

This comment was marked as off-topic.

@seanbudd seanbudd changed the base branch from master to branchFor2022.4 September 29, 2022 06:11
@seanbudd seanbudd merged commit 06c7384 into nvaccess:branchFor2022.4 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants