Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eSpeak to b17ed2d6 for 2022.4 #14203

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Oct 3, 2022

Link to issue number:

Closes #14197

Summary of the issue:

Janitorial update of eSpeak.
Fixes a regression and long standing issue with Turkish pronunciation.
Also fixes a regression in Mandarin pronunciation.

Description of user facing changes

eSpeak is updated

Description of development approach

Followed instructions in include/espeak.md.
Checked the following diffs, which are empty.

cd include/espeak
git diff 735ecdb8 b17ed2d6 src/windows/config.h
git diff 735ecdb8 b17ed2d6 Makefile.am

Testing strategy:

Tested eSpeak after building.

Known issues with pull request:

None

Change log entries:

Refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner October 3, 2022 01:04
@seanbudd seanbudd requested review from feerrenrut and removed request for a team October 3, 2022 01:04
@seanbudd
Copy link
Member Author

seanbudd commented Oct 3, 2022

I am merging this without running a PR build, as this PR has merge conflicts with master, and this is a janitorial update of eSpeak with no build changes.
Once this is merged to branchFor2022.4, a PR to merge branchFor2022.4 to master will be opened, which will ensure that the changes in this PR can build correctly.

@seanbudd seanbudd merged commit 3eef81c into branchFor2022.4 Oct 3, 2022
@seanbudd seanbudd deleted the updateEspeak2022.4 branch October 3, 2022 01:08
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 3, 2022
@seanbudd seanbudd modified the milestones: 2023.1, 2022.4 Oct 10, 2022
@alex19EP
Copy link

FYI I merged some Russian language improvements in espeak-ng/espeak-ng#1425

I understand if you don't want to update espeak again, but that would be really cool.

@seanbudd
Copy link
Member Author

@alex19EP, we will not be updating eSpeak again for 2022.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants