Skip to content

Allow compiling microsoft-ui-uiAutomation with VS 2022 #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

michaelDCurran
Copy link
Member

Link to issue number:

Taken from pr #14313 which cannot yet be merged in its entireity.

Summary of the issue:

NVDA can be compiled locally with VS 2022, but the VS 2019 build tools are required, due to the Microsoft-UI-UIAutomation project specifying the VS 2019 platform toolset by default.

Description of user facing changes

None

Description of developer facing changes

NVDA can now be fully compiled locally with Visual Studio 2022, without also requiring the 2019 build tools.

Description of development approach

  • When compiling the microsoft-ui-uiAutomation project, instruct msbuild to use the same platform toolset as the rest of NVDAHelper.

Testing strategy:

Built with VS 2022 with no VS 2019 components installed.

Known issues with pull request:

None known.

Change log entries:

New features
Changes
Bug fixes
For Developers

  • NVDA can be now fully compiled with Visual Studio 2022, with out requiring the Visual Studio 2019 build tools.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

…e platform toolset as the rest of nvdaHelper. Allowing this project to be compiled with VS 2022.
@michaelDCurran michaelDCurran requested a review from a team as a code owner November 2, 2022 11:30
Co-authored-by: Sean Budd <sean@nvaccess.org>
@michaelDCurran michaelDCurran merged commit 4b6cdfc into master Nov 3, 2022
@michaelDCurran michaelDCurran deleted the allowVS2022 branch November 3, 2022 23:17
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants