Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup #14525 bug in Firefox table nav #14554

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jan 17, 2023

Link to issue number:

Closes #14552

Summary of the issue:

A typo in #14070 prevents navigated to the first column in a table in Firefox.

Description of user facing changes

Use table navigation commands to move to the first column in firefox works again

Description of development approach

Fix typo

Testing strategy:

Test with STR in #14552

Known issues with pull request:

None

Change log entries:

Bug fixes

  • Bug fixed when navigating to the first and last column in a table in Firefox

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner January 17, 2023 01:25
@seanbudd seanbudd added this to the 2023.1 milestone Jan 17, 2023
@CyrilleB79

This comment was marked as resolved.

@seanbudd

This comment was marked as resolved.

@michaelDCurran michaelDCurran merged commit 45b05a5 into master Jan 29, 2023
@michaelDCurran michaelDCurran deleted the fixFireFoxTableNav branch January 29, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot move to first column in some tables in Firefox with NVDA 2022.4
3 participants