Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect non-config settings on synth drivers #14601

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

A synth driver inherrits from autoSettingsUtils.autoSettings.AutoSettings but overrides its loadSettings method to work around changing the voice. However, that override doesn't respect settings that aren't saved in config, like the parent class does.

Description of user facing changes

None

Description of development approach

Ensure that a synth doesn't try to get a setting from config that's not a setting stored in config.

Testing strategy:

Tested with an add-on that had synth settings with useConfig set to False. The synth was able to load again.

Known issues with pull request:

None

Change log entries:

For Developers

  • It is possible to set useConfig to False on supported settings for a synthesizer driver.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner January 31, 2023 11:06
@michaelDCurran michaelDCurran merged commit ca4fcc7 into nvaccess:master Feb 1, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants