HID Braille Driver: add more mappings for arrow keys #14713
Conversation
* space+dot1 and space+dot4 now map to upArrow and downArrow respectively, rather than braille_previousLine and braille_nextLine. In text editing this practicly does the same thing, but in non-text focus, such as in lists or on the Desktop etc, then these gestures will move up and down like with several other braille drivers. * A Braille device's dpad is now mapped to upArrow, downArrow, leftArrow, rightArrow and enter.
| "kb:enter": ("br(hidBrailleStandard):joystickCenter"), | ||
| "kb:enter": ( | ||
| "br(hidBrailleStandard):joystickCenter", | ||
| "br(hidBrailleStandard):dpadCenter", |
There was a problem hiding this comment.
"bk:dot8" (enter) and "bk:dot7" (backspace) are mapped to scripts in globalCommands.py already as they apply to all braille displays, so don't need to be explicitly mentioned in any braille driver.
| @@ -220,22 +220,39 @@ def display(self, cells: List[int]): | |||
| "br(hidBrailleStandard):panRight", | |||
| "br(hidBrailleStandard):rockerDown", | |||
| ), | |||
| "braille_previousLine": ("br(hidBrailleStandard):space+dot1",), | |||
There was a problem hiding this comment.
should we still have commands from previous and next line?
There was a problem hiding this comment.
braille_nextLine and kb_downArrow generally do the same thing, at least by default. If however you tether braille to the review cursor, then braille_nextLine will move the review cursor up and down by line, but I think this is a fairly rare usecase, and certainly none of the braille manufacturers I'm talking with seem to care. In future we could consider some kind of toggle command on the braille display to switch between panning and moving by line or something. But it seems the expectation is that joystick / dpad acts like pressing the arrow keys on the keyboard.
Link to issue number:
None
Summary of the issue:
Reported by Orbit, The Standard HID Braille driver does not provide mappings to the arrow keys as they would expect.
Currently the joystick can be used for arrow keys and enter, but not the dpad. Some Braille devices, such as the Orbit Reader, only have a dpad and no joystick.
Also, currently space+dot1 and space+dot4 are mapped to nextLine and previousLine braille commands. Manufacturers would prefer that these gestures map to up and down arrow, so that they also work in lists and on the Desktop etc.
Description of changes
When using a Braille Display via the Standard HID braille driver, the dpad can be used to emulate the arrow keys and enter. Also space+dot1 and space+dot4 now map to up and down arrow respectively.
Testing strategy:
Connected to an Orbit Reader 40 with the Standard HID braille driver:
Ensured that space+dot1 and space+dot4 emulate up and down arrow and move the focus up and down the icons.
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: