Albatross braille driver: small improvements #14844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new gestures - do not try to open port if it is not present (better log readability when log level is debug) - wrong file name in readme.md
|
Thank you @seanbudd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
none
Summary of the issue:
Added some gestures. Do not try to open port if it is not present.
Description of user facing changes
Added following gestures:
f1+home1,f9+home2|f1+end1,f9+end2|f1+eCursor1,f9+eCursor2|f1+cursor1,f9+cursor2|If there is working connection, and I/O error occurs, port presence is checked before trying to open it again. USB serial port disappears when cable is plugged out or device is powered off, thus efforts to open port are then useless. Debug level log entries are also more readable telling that port is not present instead of exception info.
Description of development approach
Added boolean function _portPresent to class ReadThread in _threading.py.
Testing strategy:
Tested with 80 cells model.
Known issues with pull request:
none known
Change log entries:
New features
Changes
Added gestures for showing braille settings dialog, accessing status bar, cycling the braille cursor shape, and toggling the braille cursor on/off.
Bug fixes
For Developers
Added boolean function _portPresent to class ReadThread in _threading.py.
Code Review Checklist: