Skip to content

Update CLDR to version 43 #14918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023
Merged

Update CLDR to version 43 #14918

merged 3 commits into from
May 31, 2023

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

Follow-up of nvaccess/nvda-cldr#5

Summary of the issue:

NVDA's CLDR data need to be updated regularly to follow CLDR releases. CLDR 43 was released on April 12th, 2023.

Description of user facing changes

CLDR character names updated, especially in translations.

Description of development approach

In nvda-cldr repo, checked out the commit e3af0878691391cc019d2e1e7965aa5756ac653a which is the one pointed by the branch main-out. This commit was created following the merge of nvaccess/nvda-cldr#5

Testing strategy:

Checked the symbol "₭" that has been corrected in French CLDR:

  • in NVDA 2023.1: "kip loatien" ("a" and "o" switched)
  • in this branch: "kip laotien"

Known issues with pull request:

None

Change log entries:

Changes
Update CLDR to version 43.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 10, 2023 16:05
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 10, 2023 16:05
@CyrilleB79 CyrilleB79 requested a review from seanbudd May 10, 2023 16:05
@seanbudd seanbudd merged commit 42945c7 into nvaccess:master May 31, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone May 31, 2023
josephsl pushed a commit to josephsl/nvda that referenced this pull request May 31, 2023
Follow-up of nvaccess/nvda-cldr#5

Summary of the issue:
NVDA's CLDR data need to be updated regularly to follow CLDR releases. CLDR 43 was released on April 12th, 2023.

Description of user facing changes
CLDR character names updated, especially in translations.

Description of development approach
In nvda-cldr repo, checked out the commit e3af0878691391cc019d2e1e7965aa5756ac653a which is the one pointed by the branch main-out. This commit was created following the merge of nvaccess/nvda-cldr#5
@CyrilleB79 CyrilleB79 deleted the cldr43 branch June 1, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants