Depend on supported command for capital pitch change

[LeonarddeR]

Link to issue number:

Closes #15262
Blocked by #15271

Summary of the issue:

When implementing a synthesizer driver, there are two ways to change pitch:

1. Change the pitch setting
2. Send a pitch command that changes the pitch for the duration of the sequence or until there is a new pitch command.

Capital pitch change uses pitch commands to change pitch for capital letters. When doing this, it calls isSupported("pitch") on the driver, which returns True when the pitch setting is supported. However in order to support capital pitch changes, the driver should implement support for the PitchCommand instead.

Description of user facing changes

None

Description of development approach

Changed all situations where isSupported("pitch") is called to generate a pitch command to check whether the PitchCommand is in supportedCommands.

Testing strategy:

Tested that capital pitch changes are still working, at least with one core.

Known issues with pull request:

This can be considered API breaking, because capital pitch changes still worked when a driver didn't offer the pitch command. However, the synthDriver class docs explicitly state that supported commands should be implemented.

Change log entries:

For Developers

• Synthesizers that need to support capital pitch changes must now explicitly declare their support for the PitchCommand in the supportedCommands attribute on the driver for pitch changes to work.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[seanbudd]

Confirming, can this be merged now that #15271 has been?

[LeonarddeR]

Sure, go ahead. Thanks!