Skip to content

Conversation

@codeofdusk
Copy link
Contributor

Link to issue number:

None

Description of the pull request:

Bump Comtypes to 1.2.0.

Testing strategy:

Verified that NVDA starts and UIA works. Extensive alpha testing required.

Known issues with pull request:

None known

Change log entry:

== Changes for developers ==

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner September 25, 2023 07:16
@codeofdusk codeofdusk requested a review from seanbudd September 25, 2023 07:16
@seanbudd seanbudd modified the milestones: 2023.3, 2024.1 Sep 26, 2023
@seanbudd
Copy link
Member

Hi @codeofdusk - can you please include the change log entry in your PR (see note)?
I'm also a bit surprised by the old PR template being used, you may need to sync your fork.

@codeofdusk
Copy link
Contributor Author

Yes, I can do that – I've historically left those out (except for changes to beta or existing entries) to avoid merge conflicts.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk

@seanbudd seanbudd merged commit dd3f621 into nvaccess:master Sep 26, 2023
seanbudd pushed a commit that referenced this pull request Oct 12, 2023
Fix-up of #15513 #15514 .

Description of how this pull request fixes the issue:
Add @codeofdusk attributions for Python 3.11 upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants