Skip to content

Conversation

@CyrilleB79
Copy link
Contributor

Link to issue number:

Fixes #15506
Fix-up of #14923

Summary of the issue:

When peforming tests for #14923, I have wrongly assumed that Excel cell formatting shortcuts were control+shift+2/3/4/5. This assumption was based on my tests with Excel's interface changed to English on my system. However, it seems that the keyboard layout when Excel is started has also an impact on the shortcuts containing digits (see discussion in #14923).
The actual shortcuts are control+2/3/4/5, as described in Microsoft documentation and as confirmed starting Excel with English GUI and English keyboard layout.

Description of user facing changes

On English systems (and probably many others), Excel cell formatting shortcuts control+2/3/4/5 will have their effect reported correctly. shift+control+2/3/4/5 will not report inappropriately formatting information on English systems.

Description of development approach

Modified the gesture definition.

Testing strategy:

Same as #14923 but taking care to have an English keyboard layout when starting Excel.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@AppVeyorBot
Copy link

See test results for failed build of commit 3a137076ee

@CyrilleB79 CyrilleB79 marked this pull request as ready for review September 26, 2023 14:16
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner September 26, 2023 14:16
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team September 26, 2023 14:16
@seanbudd seanbudd added this to the 2023.3 milestone Sep 26, 2023
@seanbudd seanbudd merged commit be9065a into nvaccess:beta Sep 26, 2023
@CyrilleB79 CyrilleB79 deleted the fixFmtShortcuts branch October 2, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants