Skip to content

Conversation

@seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 28, 2023

Link to issue number:

Clean up of #15544

Summary of the issue:

Description of user facing changes

Should be none

Description of development approach

Straight forward code deprecation or implementation of noted comments

Testing strategy:

Alpha testing needed.
Basic manual smoke test performed

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 28, 2023 02:18
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 28, 2023 02:18
@seanbudd seanbudd removed the blocked label Oct 16, 2023
Base automatically changed from py311-min to master October 16, 2023 02:50
@seanbudd seanbudd requested a review from a team as a code owner October 16, 2023 02:50
@seanbudd seanbudd requested a review from Qchristensen October 16, 2023 02:50
@AppVeyorBot
Copy link

See test results for failed build of commit 9230fb0c5f

@lukaszgo1 lukaszgo1 mentioned this pull request Oct 16, 2023
5 tasks
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 16, 2023
@codeofdusk
Copy link
Contributor

This PR resolves a number of "found unreachable objects" errors in Chrome and should be merged as soon as practical.

seanbudd pushed a commit that referenced this pull request Oct 18, 2023
Discussion in #15299
Unblocks PR #15546

Summary of the issue:
The version of Flake8 we're using is extremely old. While it worked well up to now, it does not support some newer syntactic construct in recent versions of Python (in particular walrus operator). Unfortunately we cannot update to the latest release, since it does not support flake8-tabs, nor linting a diff (the latter can be achieved using external tools).

Description of user facing changes
None

Description of development approach
Flake8 is updated to the version 4.0.1. This is the last version which supports flake8-tabs, and it also recognizes various newer language constructs in Python, by the simple fact that it was released almost 2.5 years after the version we're using currently.
@seanbudd seanbudd merged commit 1852284 into master Oct 18, 2023
@seanbudd seanbudd deleted the py311-cleanup branch October 18, 2023 08:32
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-breaking-change conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants