Skip to content

Include python3.dll in the binary distribution for use in add-ons. #15674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

mzanm
Copy link
Contributor

@mzanm mzanm commented Oct 24, 2023

Link to issue number:

fixes #15594

Summary of the issue:

NVDA add-ons that rely on .pyd files, like Resource Monitor, encounter compatibility issues due to the absence of python3.dll in NVDA's distribution. The issue becomes more complicated with NVDA's upgrade to Python 3.11, as it necessitates manually bundling multiple versions of python3.dll to maintain backward compatibility.

Description of user facing changes

None.

Description of development approach

In the setup.py file, bundle python3.dll from sys.base_prefix, which should be the python version used to build NVDA.

Testing strategy:

Override compatibility for Resource Monitor 23.10. It should function normally instead of a DLL error occurring.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mzanm
Copy link
Contributor Author

mzanm commented Oct 24, 2023

CC @josephsl

@AppVeyorBot
Copy link

See test results for failed build of commit 293fe295b7

@AppVeyorBot
Copy link

See test results for failed build of commit 5da4851253

@AppVeyorBot
Copy link

See test results for failed build of commit a5ed8df7dd

@mzanm mzanm marked this pull request as ready for review October 25, 2023 15:24
@mzanm mzanm requested a review from a team as a code owner October 25, 2023 15:24
@mzanm mzanm requested a review from michaelDCurran October 25, 2023 15:24
@seanbudd seanbudd merged commit d09bd29 into nvaccess:master Oct 26, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 26, 2023
@XLTechie
Copy link
Collaborator

XLTechie commented Oct 26, 2023 via email

@mzanm mzanm deleted the icludePython3DLL branch October 26, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11: include python3.dll as part of binary distribution
6 participants