Skip to content

Add speech.speechCanceled extension point#15700

Merged
seanbudd merged 7 commits intonvaccess:masterfrom
LeonarddeR:speechCanceled
Oct 30, 2023
Merged

Add speech.speechCanceled extension point#15700
seanbudd merged 7 commits intonvaccess:masterfrom
LeonarddeR:speechCanceled

Conversation

@LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Oct 28, 2023

Link to issue number:

Part of #14520

Summary of the issue:

There is no way for add-ons to be notified about speech cancellation.

Description of user facing changes

None, developer oriented.

Description of development approach

Added the speech.speechCanceled extension point.

Testing strategy:

Unit test.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner October 28, 2023 09:33
LeonarddeR and others added 2 commits October 28, 2023 18:29
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd seanbudd merged commit af3b003 into nvaccess:master Oct 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 30, 2023
@LeonarddeR LeonarddeR deleted the speechCanceled branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants