Update wxPython to 4.2.2a0205c7c1b #16257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
added
the
conceptApproved
seanbudd
added a commit
to nvaccess/nvda-misc-deps
that referenced
this pull request
Mar 5, 2024
NVDA PR to incorporate changes: nvaccess/nvda#16257 Generally release builds of wxPython should be used from pip. However, due to an issue in wxPython (nvaccess/nvda#15714) that has not made it to a release quality build, we are stuck on alpha snapshots. The build used is from: https://alldunn.visualstudio.com/wxPython-CI/_build/results?buildId=1246&view=results wxWidgets/Phoenix@0205c7c Windows x86 alpha builds can be found via Robin Dunn's build pipeline: https://alldunn.visualstudio.com/wxPython-CI/_build?view=runs I have asked Robin what the quality of alpha builds are - i.e. if they throw errors, log, or otherwise act differently due to not being an official release
seanbudd
requested review from
SaschaCowley,
gerald-hartig and
michaelDCurran
and removed request for
a team
michaelDCurran
approved these changes
Mar 5, 2024
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Fixes nvaccess#15714 See also nvaccess/nvda-misc-deps#32 Summary of the issue: wxPython introduced a bug in 4.2.1: wxWidgets/Phoenix#2446 This caused nvaccess#15714 wxPython is yet to release the commit which fixes this issue. However, an alpha build wheel can be incorporate The build used is from: - https://alldunn.visualstudio.com/wxPython-CI/_build/results?buildId=1246&view=results - wxWidgets/Phoenix@0205c7c Description of user facing changes Emojis and other unicode symbols are displayed properly in NVDA Description of development approach Update wxPython to an alpha snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15714
See also nvaccess/nvda-misc-deps#32
Summary of the issue:
wxPython introduced a bug in 4.2.1: wxWidgets/Phoenix#2446
This caused #15714
wxPython is yet to release the commit which fixes this issue.
However, an alpha build wheel can be incorporate
The build used is from:
Description of user facing changes
Emojis and other unicode symbols are displayed properly in NVDA
Description of development approach
Update wxPython to an alpha snapshot
Testing strategy:
Tested using emojis in the symbol pronunciation dialog to confirm #15714 is fixed
Known issues with pull request:
I have asked Robin what the quality of alpha builds are - i.e. if they throw errors, log, or otherwise act differently due to not being an official release
Code Review Checklist: