Fix sound split exception during startup on AppVeyor CI runner#16270
Merged
Conversation
5 tasks
seanbudd
reviewed
Mar 6, 2024
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…ess#16270) Closes nvaccess#16269 Fixup of nvaccess#16071 Summary of the issue: Exception _ctypes.COMError is thrown at startup on AppVeyor CI runner because hno sound device is present. Description of user facing changes N/A Description of development approach Catching and logging exception. Returning from soundSplit.initialize function so that initialization can continue. Testing strategy: Not sure how to test on AppVeyor, but judging by the exception providded - this should fix the error. Tested on my local computer to avoid syntax errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16269
Fixup of #16071
Summary of the issue:
Exception _ctypes.COMError is thrown at startup on AppVeyor CI runner because hno sound device is present.
Description of user facing changes
N/A
Description of development approach
Catching and logging exception. Returning from soundSplit.initialize function so that initialization can continue.
Testing strategy:
Not sure how to test on AppVeyor, but judging by the exception providded - this should fix the error.
Tested on my local computer to avoid syntax errors.
Known issues with pull request:
N/A
Code Review Checklist: