Skip to content

Enter focus mode when activating editable list#16325

Merged
michaelDCurran merged 4 commits intonvaccess:masterfrom
SaschaCowley:editable_list_item_focus_switch
Apr 1, 2024
Merged

Enter focus mode when activating editable list#16325
michaelDCurran merged 4 commits intonvaccess:masterfrom
SaschaCowley:editable_list_item_focus_switch

Conversation

@SaschaCowley
Copy link
Member

Link to issue number:

Fixes #13642

Summary of the issue:

In Firefox, pressing enter on a list item in an editable region does not switch to focus mode.

Description of user facing changes

NVDA will switch to focus mode when pressing enter on an editable list item.

Description of development approach

Restricted the cases in which NVDA will drop the controlTypes.State.EDITABLE to exclude objects with a role of controlTypes.Role.LIST and LISTITEM.

Testing strategy:

Tested using the test case given in #13642. Tested in a Google sheet with Braille mode enabled to make sure this does not regress changes implemented in #7935.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation: None needed
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@SaschaCowley SaschaCowley requested a review from a team as a code owner March 20, 2024 03:51
@michaelDCurran michaelDCurran merged commit 61fa173 into nvaccess:master Apr 1, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 1, 2024
@SaschaCowley SaschaCowley deleted the editable_list_item_focus_switch branch August 22, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Firefox, pressing enter on an editable list item does not switch to focus mode

3 participants