Properly support MSVC 14.40 toolset for getting the universal CRT files

[LeonarddeR]

Link to issue number:

None

Summary of the issue:

Microsoft is about to introduce Visual Studio 2022 version 17.10 in the near future. They decided to change the minor toolset version number, so we're going from MSVC 14.39 to 14.40.
See this blog post for details.
Note that they'll stick with version 143 in the crt version string, which is very weird.

Description of user facing changes

Building NVDA on visual studio 2022 version 17.10 (to be released) will work correctly.

Description of development approach

Rather than expecting all toolset directories to start with 14.3, we expect them to start with the major version part only (i.e. 14).

Testing strategy:

• Test with Visual Studio 2022 Preview. Note that you have to patch scons for this to work.
  In the scons directory: tool\MSCommon\vc.py, change line 680 by adding the -prerelease parameter:
  vswhere_cmd = [vswhere_path] + vswhere_version_args + ["-prerelease", "-property", "installationPath"]
• Visual Studio 2022 stable is covered by appveyor.

Known issues with pull request:

None known

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• [] Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[AppVeyorBot]

• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/6wai5q6l4svb4hco/artifacts/output/
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.2,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  FINISH_END 3.0

See test results for failed build of commit 0f2ba7c6c7

[AppVeyorBot]

• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ommuoa4oqto5n7af/artifacts/output/
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.1,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  FINISH_END 3.7

See test results for failed build of commit 403bab36ad

[AppVeyorBot]

• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/bgag31wah35sw3pr/artifacts/output/
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.1,
  INSTALL_END 1.1,
  BUILD_START 0.0,
  FINISH_END 3.0

See test results for failed build of commit e6729cfdab

[AppVeyorBot]

• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/r8w89nav3kq0j5o1/artifacts/output/
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.1,
  INSTALL_END 1.1,
  BUILD_START 0.0,
  FINISH_END 3.0

See test results for failed build of commit 01e17c530c

[LeonarddeR]

This is ready for review. I'm tempted to leave out a changelog entry, since it's only a cosmetic build system change.

[XLTechie]

@LeonarddeR wrote:

I'm tempted to leave out a changelog entry, since it's only a cosmetic build system change.

Those of us who work on the build system, or use the instructions for running our own Appveyor builds, would appreciate a changelog entry.

[LeonarddeR]

In that case, I'm happy to add one as soon as the changelog for 2024.3 has been initiated.

[seanbudd]

That should be ready now, thanks for your patience