Properly indicate wrapping of wx.CallAfter while monkeypatching #16520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The monkeypatch for
wx.CallAfterdidn't indicate wrapping.Description of user facing changes
None
Description of development approach
Imported wraps from functools, and added
@wrapsto the wrapper.From a build after the modification:
Also converted the
apply()function's comment into a docstring.Testing strategy:
Ran with the fix in a portable copy of NVDA.
I found no difficulties.
Known issues with pull request:
I do not know what original STR prompted the wrapping of this callable. As far as I can tell, it was originally introduced in 528d570, but there is no commit message for this change.
Did some issue/pr searches, but couldn't find any reasoning there either. So I don't know what caused the wrapping, to test that specifically. Do you remember, @michaelDCurran?
Code Review Checklist: