Fix regression where many blank lines were reported in browse mode

[SaschaCowley]

Link to issue number:

Fixes #16554

Summary of the issue:

#16471 introduced a regression whereby many blank lines were reported in browse mode.

Description of user facing changes

Extraneous blank lines are no longer reported in browse mode.

Description of development approach

Updated checks in gecko_ia2.cpp:

• Check that the length of name is non-zero (SysStringLen returns 0 if the BSTR passed is null)
• Added check that description's value is not the empty string, as checking that it has a value is necessary but not sufficient.

Testing strategy:

Tested reading the PR for #16471 as described in #16554. Also tested as described in #16471 to ensure changes did not break the new behaviour.

Known issues with pull request:

N/A

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[cary-rowen]

Hi,
Shouldn't regression fixes be for beta versions?

[seanbudd]

@cary-rowen - this regression is on alpha, caused by a PR targeting 2024.3. It's not in the 2024.2 code.

@SaschaCowley - I assume you are still working on this as the diff appears to be empty, so I've marked this a draft

[cary-rowen]

Sorry, I misremembered this

[LeonarddeR]

Thanks for fixing it!

[Adriani90]

It seems there are still blank lines added from time to time to the virtual document when web pages update content dynamically.E.g. on Github insights page while the time stamps for the issues / PRs are updating.

[SaschaCowley]

Can you open a new issue for this, and if possible provide a concrete repro case?

[Adriani90]

I can try to report a concrete case and isolate it as far as possible, it seems it happens only in Firefox.