Conversation
See test results for failed build of commit fa51eedf4c |
|
It appears that the Dutch table ( |
|
@egli Could you chime in here? It looks like the Dutch table will need some special handling by NVDA"s build system. I hope we can handle this. |
LeonarddeR
left a comment
LeonarddeR
left a comment
There was a problem hiding this comment.
It looks like scons has m4 support, but it will most likely require some extra tool not everyone has installed by default.
|
|
||
| This release adds support for Unicode Normalization to speech and braille output. | ||
| This can be useful when reading characters that are unknown to a particular speech synthesizer or braille table and which have a compatible alternative, like the bold and italic characters commonly uses on social media. | ||
| This can be useful when reading characters that are unknown to a particular speech synthesizer or braille table and which have a compatible alternative, like the bold and italic characters commonly used on social media. |
There was a problem hiding this comment.
This is strictly spoken unrelated. I think this is more suitable for a general documentation follow up pr. That said, I'm sorry for the typos.
How do you build liblouis? The dutch tables should be generated when you run |
|
We use the SCons build system that simply compiles all the c code with the Clang bundled with vc++, similar to how the nmake file does it. |
See test results for failed build of commit f98bc9dafb |
|
codeofdusk#3 should get us going |
|
@egli For your reference, we will add a Windows binary build of m4 to our repo with misc dependencies, and then will manually throw all *.in files from the tables dir into m4. |
|
One thing that we (liblouis) could consider is to try to ship pre-converted tables in the distribution tar ball. In other words: Convert the |
|
@egli No, We're including liblouis' git repository as a submodule in the NVDA repo. I think that's fine, it was, at least up until now, a pretty trivial action to update it. |
See test results for failed build of commit 3d97a71c9a |
LeonarddeR
added
blocked
component/liblouis
|
This is currently blocked by nvaccess/nvda-misc-deps#33 |
seanbudd
added
the
conceptApproved
Bundle m4 with miscdeps to compile liblouis tables containing macros. See also nvaccess/nvda#16652
|
@codeofdusk Now nvaccess/nvda-misc-deps#33 is closed, could you update miscDeps? |
codeofdusk
force-pushed
the
liblouis-3.30
branch
from
04e4e65 to
e6acb31
Compare
WalkthroughThe updates primarily involve upgrading subproject commit hashes and the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
codeofdusk
force-pushed
the
liblouis-3.30
branch
from
e6acb31 to
b2821c1
Compare
See test results for failed build of commit b44896973b |
|
Unit tests are still failing here |
See test results for failed build of commit 5f5d537344 |
|
It looks like the changes to sconstruct wheren't merged in correctly. |
5 participants
Link to issue number:
None
Summary of the issue:
Liblouis 3.30.0 has been released, adding many new Braille tables.
Description of how this pull request fixes the issue:
Update Liblouis and add new tables.
Testing strategy:
Alpha testing
Known issues with pull request:
None known
Code Review Checklist:
Summary by CodeRabbit
New Features
Documentation
liblouis(3.30.0).Chores
liblouisandmiscDepsto their latest versions.