Update NSIS 3.09 to 3.10

[dpy013]

Link to issue number:

Summary of the issue:

pull

Description of user facing changes

Updating NSIS

Description of development approach

none

Testing strategy:

Requires a test compilation build

Known issues with pull request:

none

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

Summary by CodeRabbit

• New Features
  • Updated Unicode CLDR for improved language support.
  • Enhanced NVDA screen reader reporting for better accessibility.
  • Improved Python console behavior for a smoother user experience.
  • Upgraded NSIS installer from version 3.09 to 3.10 for better performance and stability.

[dpy013]

@coderabbitai review

[coderabbitai]

Walkthrough

The recent updates involve two primary changes: the include/nsis subproject's commit reference has been updated to a new version, and the user documentation has been enhanced to reflect updates related to Unicode CLDR, NVDA screen reader improvements, Python console behavior enhancements, and the NSIS upgrade from version 3.09 to 3.10.

Changes

Files/Paths	Change Summary
include/nsis	Updated commit reference from 012b0ddf9274ebe3907d6ea157b2dbaca4ee7074 to 1612bc13f8b907de003053b6544cb7694e9db1cd.
user_docs/en/changes.md	Documented updates regarding Unicode CLDR, NVDA screen reader, Python console behavior, and NSIS upgrade from 3.09 to 3.10.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[seanbudd]

@dpy013 - have you tested this in NVDA yet with a build?

I've checked the files changed and everything looks ok.

[dpy013]

@dpy013 - have you tested this in NVDA yet with a build?

I've checked the files changed and everything looks ok.

Currently only the portable version has been tested, because it is using the unit's computer, so only the portable version can be created for testing.
It is recommended that if you have time, you can test the part of the installation to the computer.

[seanbudd]

@dpy013 - you should be able to create an installable build with scons launcher. You can also use the installer generated from AppVeyor in this PR.

[dpy013]

Just used nvda_snapshot_pr16674-32353 to test the two steps of creating a portable version, and installing it to the computer, here are the two logs:
nvda-I.log
nvda-P.log
The test results are:
NVDA Creating a portable version, and installing it to your computer, both steps can be done.

[seanbudd]

Thanks, please update the reference to the NSIS submodule and this can be merged

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/qt52cgb9l6yf17mx/artifacts/output/nvda_snapshot_pr16674-32360,b3df3ee0.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.1,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 12.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 2.4,
  FINISH_END 0.2

See test results for failed build of commit b3df3ee01a