Update py2exe to 0.13.0.2 by dpy013 · Pull Request #16907 · nvaccess/nvda

dpy013 · 2024-07-24T23:31:46Z

-->

Link to issue number:

Release Notes

Summary of the issue:

Updating py2exe to 0.13.0.2
This is a bugfix release, check the release link above for the exact changelog!

Description of user facing changes

There are no user-side changes, this is an update to the build component

Description of development approach

Updated the py2exe version of the requirements.txt file
and did a local build with scons launcher version=py2exe-test

Testing strategy:

Need to see if appveyor can be built successfully

Known issues with pull request:

Not found at the moment

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

Summary by CodeRabbit

Chores
- Updated the specification of the py2exe dependency to a fixed version for improved clarity and more predictable builds.

The following is the changelog for 0.13.0.2: https://github.com/py2exe/py2exe/releases/tag/v0.13.0.2 Signed-off-by: dpy013 <26911141+dpy013@users.noreply.github.com>

coderabbitai · 2024-07-24T23:31:57Z

Walkthrough

The change involves updating the requirements.txt file to specify the py2exe dependency more clearly. The previous method included a reference to a specific GitHub commit, which could lead to unpredictable builds. The new update sets a fixed version, 0.13.0.2, enhancing the clarity and stability of the dependency management process while leaving all other dependencies unchanged.

Changes

File	Change Summary
requirements.txt	Changed `py2exe` dependency from a GitHub commit reference to a fixed version `0.13.0.2` for clarity and predictability.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

AppVeyorBot · 2024-07-25T01:00:17Z

PASS: Translation comments check.
PASS: License check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests (tags: installer NVDA). See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/794407q6yxvjsc0a/artifacts/output/nvda_snapshot_pr16907-33029,feb9e5ec.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.2,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 12.4,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 18.5,
FINISH_END 0.2

See test results for failed build of commit feb9e5ec69

seanbudd · 2024-07-29T01:42:35Z

@dpy013 - from the change log there's a few notable things:

Newer versions of setuptools are now supported. Can you update us to the latest setuptools too?
@lukaszgo1 made a contribution to fix an issue we were seeing in NVDA, Impossible to specify different version info for each of the binaries with the new freeze API. py2exe/py2exe#193. It would be nice to restore that information to our builds now that it is possible again - see changes to setup.py in https://github.com/nvaccess/nvda/pull/15544/files

seanbudd · 2024-07-29T02:49:12Z

Actually my mistake, we already fixed up the version info stuff fixed by Lukasz in b8124fb
However could you still please bump setuptools

seanbudd · 2024-07-29T04:24:03Z

 			"pip",
 			"install",
-			"setuptools==69.5.1",
+			"setuptools==70",


setuptools is also mentioned in pyproject.toml, please ensure this is updated to reference the latest setuptools.

The latest setuptools is 72, have you tested this version? if so, what didn't work.

Please fixup the comment above which references py2exe and setuptools

seanbudd · 2024-07-29T05:10:55Z

 			"pip",
 			"install",
-			"setuptools==70",
+			"setuptools==72.0.0",


I think we want to match any 72 subversion

Suggested change

"setuptools==72.0.0",

"setuptools~=72.0",

As requested previously, please fixup the code comment above this line which references py2exe and setuptools

seanbudd · 2024-07-29T05:11:29Z

@@ -1,5 +1,5 @@
 [build-system]
-requires = ["setuptools<70", "wheel"]
+requires = ["setuptools<72.0.0", "wheel"]


We don't want to pin less than 72, we want to use 72

Suggested change

requires = ["setuptools<72.0.0", "wheel"]

requires = ["setuptools~=72.0", "wheel"]

Local compilation has been installed correctly
Collecting setuptools==72
e8/setuptools-72.0.0-py3-none-any.whl (2.3 MB)

Doesn't matter. Please update pyproject.toml to match setup.py.
They should refer to the same setuptools version

dpy013 · 2024-07-30T08:47:00Z

Hello, I've reorganized the section on setuptools to
Uniformly assign setuptools to the modified version of the comment: 72.0.
Instead of the original 72.0.0.
Now setuptools installed by running scons source will select from the 72.0 major version, e.g. the original 72.0.0.
Also re-optimized changes
Please let me know if you have any more questions.

AppVeyorBot · 2024-07-30T11:33:07Z

PASS: Translation comments check.
PASS: License check.
PASS: Unit tests.
FAIL: Lint check. See test results and lint artifacts for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/l0d57h1sfbjdb8xn/artifacts/output/nvda_snapshot_pr16907-33113,a65b06a7.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.3,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 12.6,
TESTSETUP_START 0.0,
TESTSETUP_END 0.3,
TEST_START 0.0,
TEST_END 18.4,
FINISH_END 0.1

See test results for failed build of commit a65b06a7f9

seanbudd · 2024-07-30T23:53:10Z

 			"pip",
 			"install",
-			"setuptools==69.5.1",
+			"setuptools==72.0",


Suggested change

"setuptools==72.0",

"setuptools~=72.0",

As requested twice previously, please fixup the code comment above this line which references py2exe and setuptools

# py2exe is not compatible with setuptools 70+ # wheel must be manually installed when creating an non-isolated build with a custom setuptools version.

should be replaced with

# wheel must be manually installed when creating an non-isolated build with a custom setuptools version.

seanbudd · 2024-07-30T23:54:30Z

@@ -1,5 +1,5 @@
 [build-system]
-requires = ["setuptools<70", "wheel"]
+requires = ["setuptools<72.0", "wheel"]


Suggested change

requires = ["setuptools<72.0", "wheel"]

requires = ["setuptools~=72.0", "wheel"]

seanbudd · 2024-07-31T01:20:45Z

+### Changes
+
+* Component updates:
+  * Updated py2exe to 0.13.0.2 (#16907, @dpy013)
+  * Updated setuptools to 72.0 (#16907, @dpy013)


This section should be below "New Features" I'm not sure why/how it was missed when starting this release

Update py2exe to 0.13.0.2

05052bd

The following is the changelog for 0.13.0.2: https://github.com/py2exe/py2exe/releases/tag/v0.13.0.2 Signed-off-by: dpy013 <26911141+dpy013@users.noreply.github.com>

dpy013 requested a review from a team as a code owner July 24, 2024 23:31

dpy013 requested a review from seanbudd July 24, 2024 23:31

dpy013 marked this pull request as draft July 25, 2024 01:47

dpy013 marked this pull request as ready for review July 29, 2024 03:10

seanbudd reviewed Jul 29, 2024

View reviewed changes

Comment thread user_docs/en/changes.md Outdated

seanbudd reviewed Jul 29, 2024

View reviewed changes

Comment thread requirements.txt Outdated

seanbudd marked this pull request as draft July 29, 2024 04:25

dpy013 marked this pull request as ready for review July 29, 2024 05:10

seanbudd reviewed Jul 29, 2024

View reviewed changes

Comment thread user_docs/en/changes.md Outdated

seanbudd marked this pull request as draft July 29, 2024 06:01

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jul 30, 2024

dpy013 added 5 commits July 30, 2024 15:36

Fix spaces

a3482f2

Add py2exe changes

d6958b3

Using setuptools to 72.0

6f94887

Fixing changes about py2exe symbols

6c02e41

Merge branch 'master' into py2-latest

cc8b96a

seanbudd reviewed Jul 30, 2024

View reviewed changes

dpy013 added 2 commits July 31, 2024 08:58

Merge branch 'master' into py2-latest

c796eb3

Fix the issues mentioned in the comments

3bd5811

seanbudd reviewed Jul 31, 2024

View reviewed changes

Comment thread venvUtils/ensureVenv.py Outdated

seanbudd and others added 2 commits July 31, 2024 11:22

Update venvUtils/ensureVenv.py

9e54f23

Merge branch 'master' into py2-latest

4fef5f3

seanbudd marked this pull request as ready for review July 31, 2024 01:23

seanbudd approved these changes Jul 31, 2024

View reviewed changes

seanbudd merged commit 410e42e into nvaccess:master Jul 31, 2024

dpy013 deleted the py2-latest branch July 31, 2024 03:47

	requires = ["setuptools<72.0.0", "wheel"]
	requires = ["setuptools~=72.0", "wheel"]

	requires = ["setuptools<72.0", "wheel"]
	requires = ["setuptools~=72.0", "wheel"]

Uh oh!

Conversation

dpy013 commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

AppVeyorBot commented Jul 25, 2024

Uh oh!

seanbudd commented Jul 29, 2024

Uh oh!

seanbudd commented Jul 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

seanbudd Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanbudd Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dpy013 commented Jul 30, 2024

Uh oh!

AppVeyorBot commented Jul 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dpy013 commented Jul 24, 2024 •

edited

Loading

coderabbitai Bot commented Jul 24, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

seanbudd Jul 29, 2024 •

edited

Loading

seanbudd Jul 29, 2024 •

edited

Loading