Fix copying add-ons to the system profile#19511
Merged
Merged
Conversation
5 tasks
seanbudd
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to #19446
Summary of the issue:
#19446 introduced the ability to select which add-ons should be copied to the system profile (now described to users as "NVDA's system-wide configuration"). Early in the prototype phase, I underscore-prefixed the new
addonsToCopyparameter tosetSystemConfigToCurrentConfig. I removed the underscore late in the dev/testing process, so late that I didn't do enough testing to ensure that every instance was renamed.Description of user facing changes:
Copying configuration to the system profile works again.
Description of developer facing changes:
None.
Description of development approach:
Corrected the name of the parameter in
gui.settingsDialogs.GeneralSettingsPanel.onCopySettings. Searchedsource/for any other instances of_addonsToCopyand found none.Testing strategy:
Created a dist. Installed from same. Copied settings to system settings, with and without add-ons installed and selected.
Known issues with pull request:
None
Code Review Checklist: