Skip to content

Fix copying add-ons to the system profile#19511

Merged
SaschaCowley merged 1 commit into
betafrom
fix-p19446
Jan 27, 2026
Merged

Fix copying add-ons to the system profile#19511
SaschaCowley merged 1 commit into
betafrom
fix-p19446

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

Link to issue number:

Follow-up to #19446

Summary of the issue:

#19446 introduced the ability to select which add-ons should be copied to the system profile (now described to users as "NVDA's system-wide configuration"). Early in the prototype phase, I underscore-prefixed the new addonsToCopy parameter to setSystemConfigToCurrentConfig. I removed the underscore late in the dev/testing process, so late that I didn't do enough testing to ensure that every instance was renamed.

Description of user facing changes:

Copying configuration to the system profile works again.

Description of developer facing changes:

None.

Description of development approach:

Corrected the name of the parameter in gui.settingsDialogs.GeneralSettingsPanel.onCopySettings. Searched source/ for any other instances of _addonsToCopy and found none.

Testing strategy:

Created a dist. Installed from same. Copied settings to system settings, with and without add-ons installed and selected.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@SaschaCowley SaschaCowley added this to the 2026.1 milestone Jan 26, 2026
@SaschaCowley SaschaCowley marked this pull request as ready for review January 26, 2026 21:12
@SaschaCowley SaschaCowley requested a review from a team as a code owner January 26, 2026 21:12
@SaschaCowley SaschaCowley requested a review from seanbudd January 26, 2026 21:12
@SaschaCowley SaschaCowley merged commit 9f79e0a into beta Jan 27, 2026
72 of 75 checks passed
@SaschaCowley SaschaCowley deleted the fix-p19446 branch January 27, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug/regression release/blocking this issue blocks the milestone release release/blocking-beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants