Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web conference plugin. Removes the progress bar that is used to show microphone strength. #5888

Merged
merged 2 commits into from Jul 18, 2016

Conversation

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Apr 18, 2016

Web conference plugin. Removes the progress bar that is used to announce the level of the microphone indicator (how strong the mic signal is). Causes NVDA to speak and beep constantly if this isn't installed.
This plugin is used in many chat rooms for various things including
http://www.out-of-sight.net/hints/install.html

…nce the level of the microphone indicator (how strong the mic signal is). Causes NVDA to speak and beep constantly if this isn't installed.
import appModuleHandler
from NVDAObjects.behaviors import ProgressBar
import controlTypes
import ui

This comment has been minimized.

@josephsl

josephsl Jun 6, 2016
Collaborator

During merging, we could just remove extra imports and add headers (a trivial thing that can be done by Jamie or others). Thanks, looks fine to me.

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Jun 30, 2016

Please add standard NVDA file comments to the top of the file, including a copyright line such as:
#Copyright (C) 2016 Derek Riemer

It looks like controlTypes and UI are not used, so please remove their import statements.

Thanks

Remove unneccessary imports .
Fix Copyright information.
cc @michaelDCurran
michaelDCurran added a commit that referenced this pull request Jul 1, 2016
@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jul 1, 2016

Incubated in 31d9e02.

@michaelDCurran michaelDCurran merged commit f501e4c into nvaccess:master Jul 18, 2016
@jcsteh jcsteh added this to the 2016.3 milestone Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants