Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5591 - HTML 5 structural elements in IE #6044

Merged
merged 2 commits into from Jul 11, 2016

Conversation

Projects
None yet
3 participants
@feerrenrut
Copy link
Contributor

commented Jun 7, 2016

Issue: NVDA does not recognise HTML 5 structural elements in IE
See #5591

Added a mapping for HTML elemetns to ARIA landmark roles which
is now considered when looking for landmarks.

Fix issue #5591
Issue: NVDA does not recognise HTML 5 structural elements in IE
See #5591

Added a mapping for HTML elemetns to ARIA landmark roles which
is now considered when looking for landmarks.
@@ -122,6 +122,7 @@ def _normalizeControlField(self,attrs):
# MSHTML puts the unavailable state on all graphics when the showing of graphics is disabled.
# This is rather annoying and irrelevant to our users, so discard it.
states.discard(controlTypes.STATE_UNAVAILABLE)
ariaRoles.append(aria.htmlNodeNameToAriaLandmarkRoles.get(nodeName.lower()))

This comment has been minimized.

Copy link
@jcsteh

jcsteh Jun 8, 2016

Contributor

nit: aria.htmlNodeNameToAriaLandmarkRoles.get might return None if there was no matching key. Having None in the ariaRoels list doesn't break anything right now, but it is odd and it might be confusing in future. Perhaps something like this:

lRole = aria.htmlNodeNameToAriaLandmarkRoles.get(nodeName.lower())
if lRole:
    ariaRoles.append(lRole)

@feerrenrut feerrenrut self-assigned this Jul 6, 2016

@feerrenrut feerrenrut merged commit c6ec2de into master Jul 11, 2016

feerrenrut added a commit that referenced this pull request Jul 11, 2016

Update changes list for #6044
In Internet Explorer, HTML 5 structural elements are now recognised
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.