Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to create a portable copy with the use of command line parameters #6329

Merged
merged 5 commits into from Oct 2, 2017

Conversation

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Sep 2, 2016

  • --create-portable: creates a new portable copy and starts it after creation
  • --create-portable-silent: creates a new portable copy and shuts down NVDA

Both parameters depend on the --portable-path parameter, which has to contain the path to the new portable copy.

IN the process, added a new checkbox to the create portable copy dialog which allows for starting the new copy after installation.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Sep 2, 2016

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Sep 3, 2016

Sure:

  1. At @BabbageCom, we deliver USB
    flash drives to our customers containing NVDA along with Nuance
    Vocalizer. However, many customers seem to lack the"skills to
    manually update their USB flash drive to"contain the most recent
    version of NVDA. With the inclusion of this pull request, things
    can get much easier for them and for us if we deliver them a
    simple script which deploys the most recent NVDA version to
    their USB flash drive using these command line parameters.
2. Apart from this, every user will be able to update their
flash drive portable copy with just two command line parameters
added to the launcher, rather than following the procedure of
starting a launcher, navigating to the create portable copy
option, manually filling in the path, creating the copy,
navigating to the new portable copy path, closing the current
copy of NVDA and starting the new one.
  1. These parameters can also be
    used in the case current #4263 code is polished some more.
    Although there are some conserns about automatically updating
    portable copies, we can use the portable-path parameter to have
    the desired portable directory automatically filled in into the
    create portable directory window, for example.
…nd line parameters (#6281:

	* --create-portable: creates a new portable copy and starts it after creation
	* --create-portable-silent: creates a new portable copy and shuts down NVDA

Both parameters depend on the --portable-path parameter, which has to contain the path to the new portable copy.

IN the process, added a new checkbox to the create portable copy dialog which allows for starting the new copy after installation.
@leonardder leonardder force-pushed the BabbageCom:i6281 branch from 2c7fe5f to 3fa163b Sep 7, 2016
@leonardder leonardder requested a review from feerrenrut Aug 29, 2017
feerrenrut added a commit that referenced this pull request Aug 30, 2017
Merge remote-tracking branch 'origin/pr/6329' into next
@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Aug 30, 2017

Sorry @feerrenrut, realised that command line parameters should be added to the user guide.

@@ -2471,6 +2471,9 @@ Following are the command line options for NVDA:
| None | --no-sr-flag | Don't change the global system screen reader flag |
| None | --install | Installs NVDA (starting the newly installed copy) |
| None | --install-silent | Silently installs NVDA (does not start the newly installed copy) |
| None | --create-portable | Creates a portable copy of NVDA (starting the newly created copy) |
| None | --create-portable-silent | Creates a portable copy of NVDA (does not start the newly installed copy) |
| None | portable-path=PORTABLEPATH | The path where a portable copy will be created |

This comment has been minimized.

@feerrenrut

feerrenrut Sep 4, 2017
Member

Should this argument start with -- ?
Also could you document the dependencies between the arguments?

…ent depend on --portable-path for real this time
feerrenrut added a commit that referenced this pull request Sep 11, 2017
Merge remote-tracking branch 'origin/pr/6329' into next
@feerrenrut feerrenrut merged commit 14898e7 into nvaccess:master Oct 2, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 2, 2017
feerrenrut added a commit that referenced this pull request Oct 2, 2017
@josephsl josephsl mentioned this pull request Oct 15, 2017
@leonardder leonardder deleted the BabbageCom:i6281 branch Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants