Minor speech viewer tweaks #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the speechviewer window is closed without using the NVDA menu, the checkmark in the menu is now updated.
|
@jcsteh Would you mind taking a look at this? |
| if not isActive: | ||
| return | ||
| isActive=False | ||
| _onActiveChanged(isActive) |
There was a problem hiding this comment.
I understand the desire to use dependency injection here, rather than calling a global. However, I'm concerned that some external code might call activate and not pass a callable, thus breaking the invariant that the check box should be checked while the Speech Viewer is open and unchecked when it's closed. There are ways we can redesign this to be a bit cleaner, but for now, I think calling gui.mainFrame.onSpeechViewerEnabled is clearer.
|
@jcsteh Mind taking another look at this one? |
| isActive=False | ||
|
|
||
| def activate(onActiveChanged = lambda isNowActive: None): | ||
| def activate(): | ||
| """ | ||
| Function to call to trigger the speech viewer window to open. | ||
| onActiveChanged - function object that takes a boolean which is true if the speechviewer is active or false if it is no longer active. |
There was a problem hiding this comment.
nit: This parameter has been removed, but still in docstring.
|
Ship it! :) |
feerrenrut
added a commit
that referenced
this pull request
Sep 9, 2016
feerrenrut
added a commit
that referenced
this pull request
Sep 9, 2016
feerrenrut
added a commit
that referenced
this pull request
Sep 23, 2016
After being closed via the task bar or the alt+F4 shortcut, the speech viewer checkbox status in the NVDA menu will now reflect the actual visibility of the window. (#6340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the NVDA menu speechviewer checkbox status does not reflect the actual visibility of the window:
Steps to reproduce:
Modified the change log for the "speech viewer on startup" feature to include information on how to use this feature.
User guide changes, include information about: