New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor speech viewer tweaks #6340

Merged
merged 4 commits into from Sep 23, 2016

Conversation

Projects
None yet
3 participants
@feerrenrut
Contributor

feerrenrut commented Sep 6, 2016

Fixes an issue where the NVDA menu speechviewer checkbox status does not reflect the actual visibility of the window:
Steps to reproduce:

  • Open speechviewer via menu
  • close via taskbar (or alt+F4)
  • look at nvda menu again, notice that speechviewer is still checked

Modified the change log for the "speech viewer on startup" feature to include information on how to use this feature.

User guide changes, include information about:

  • the speech viewer checkbox
  • the speech viewer position and size

feerrenrut added some commits Sep 6, 2016

Speechviewer check mark reflects state
When the speechviewer window is closed without using the NVDA menu, the
checkmark in the menu is now updated.
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Sep 6, 2016

Contributor

@jcsteh Would you mind taking a look at this?

Contributor

feerrenrut commented Sep 6, 2016

@jcsteh Would you mind taking a look at this?

Show outdated Hide outdated source/speechViewer.py Outdated
Show outdated Hide outdated user_docs/en/userGuide.t2t Outdated
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Sep 8, 2016

Contributor

@jcsteh Mind taking another look at this one?

Contributor

feerrenrut commented Sep 8, 2016

@jcsteh Mind taking another look at this one?

Show outdated Hide outdated source/speechViewer.py Outdated
@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Sep 8, 2016

Contributor

Ship it! :)

Contributor

jcsteh commented Sep 8, 2016

Ship it! :)

feerrenrut added a commit that referenced this pull request Sep 9, 2016

incubates #6340
Merge branch 'minorSpeechViewerTweaks' into next

@nvaccessAuto nvaccessAuto assigned feerrenrut and unassigned jcsteh Sep 9, 2016

feerrenrut added a commit that referenced this pull request Sep 9, 2016

incubates #6340
re issue #6101
Merge branch 'i6101_SymbolsListCtrl' into next

@feerrenrut feerrenrut merged commit b996b42 into master Sep 23, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Sep 23, 2016

feerrenrut added a commit that referenced this pull request Sep 23, 2016

Update changes file for PR #6340
After being closed via the task bar or the alt+F4 shortcut, the speech viewer checkbox status in the NVDA menu will now reflect the actual visibility of the window. (#6340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment