Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
nvdaHelperRemote: Use SendMessageCallback instead of SendMessage to execute most cross-thread calls. #6380
This is necessary for Firefox multi-process. When we use SendMessage to execute calls in the main thread, outgoing cross-process COM calls fail with RPC_E_CANTCALLOUT_ININPUTSYNCCALL; see Mozilla bug 1297549 comment 14. We avoid this by instead using PostMessage and waiting on an event.
As discussed, I tested this with Firefox, Chrome and IE in Windows 10, as well as Firefox and IE in Windows XP, and did not encounter any crashes or other instability. Hopefully, this multiple CRT thing won't be an issue, but if it is, it should get picked up during incubation.
added a commit
this pull request
Sep 22, 2016
Would this affect anything else using IE code such as Outlook Express etc?