Enable and disable add-ons with keyboard accelerators #6388

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@leonardder
Collaborator

leonardder commented Sep 19, 2016

I noticed that, in the add-ons gui, the accelerators were missing for enabling and disabling add-ons. I added them in this pr, since it makes it much easier to walk through the add-ons list, enabling and disabling add-ons on the fly with the corresponding accelerators. I didn't use the same accelerator for enabling and disabling due to two reasons:

  1. There is no logical letter to use for both enabling and disabling, so the accelerator would be a non-obvious one
  2. You will always be sure what the corresponding accelerator (either e or d) does.
It is now possible to enable and disable add-ons from the add-ons lis…
…t using keyboard accelerators alt+e and alt+d respectively
@jcsteh

jcsteh approved these changes Sep 20, 2016

Looks good. Thanks!

jcsteh added a commit that referenced this pull request Sep 20, 2016

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Sep 22, 2016

Collaborator

Hi:

Joseph actually didn't put this in because he thought it made a good UI
statement, which is that a user should only disable an add-on while
doing something purposeful while disabling an add-on, but I tend to
disagree with him on this point. I thought I'd point it out
nevertheless, since the question had been brought up before.

On 9/19/2016 2:55 AM, Leonard de Ruijter wrote:

I noticed that, in the add-ons gui, the accelerators were missing for
enabling and disabling add-ons. I added them in this pr, since it
makes it much easier to walk through the add-ons list, enabling and
disabling add-ons on the fly with the corresponding accelerators. I
didn't use the same accelerator for enabling and disabling due to two
reasons:

  1. There is no logical letter to use for both enabling and disabling,
    so the accelerator would be a non-obvious one
  2. You will always be sure what the corresponding accelerator (either
    e or d) does.

    You can view, comment on, or merge this pull request online at:

#6388

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6388, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivVXG0b_XNv573qhtypECZrASQiEnks5qrk3_gaJpZM4KAQy9.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

Collaborator

derekriemer commented Sep 22, 2016

Hi:

Joseph actually didn't put this in because he thought it made a good UI
statement, which is that a user should only disable an add-on while
doing something purposeful while disabling an add-on, but I tend to
disagree with him on this point. I thought I'd point it out
nevertheless, since the question had been brought up before.

On 9/19/2016 2:55 AM, Leonard de Ruijter wrote:

I noticed that, in the add-ons gui, the accelerators were missing for
enabling and disabling add-ons. I added them in this pr, since it
makes it much easier to walk through the add-ons list, enabling and
disabling add-ons on the fly with the corresponding accelerators. I
didn't use the same accelerator for enabling and disabling due to two
reasons:

  1. There is no logical letter to use for both enabling and disabling,
    so the accelerator would be a non-obvious one
  2. You will always be sure what the corresponding accelerator (either
    e or d) does.

    You can view, comment on, or merge this pull request online at:

#6388

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6388, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivVXG0b_XNv573qhtypECZrASQiEnks5qrk3_gaJpZM4KAQy9.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

@jcsteh jcsteh merged commit 086386a into nvaccess:master Oct 11, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment